FreeBSD/ports
1
0
Fork 0
mirror of https://git.freebsd.org/ports.git synced 2026-06-02 11:08:52 +00:00
Code Issues Projects Releases Wiki Activity

www/iridium: update to 2026.05.148.3

Browse Source
This commit is contained in:
Robert Nagy
2026-06-02 08:25:46 +02:00
parent dfe8bdf421
commit 5f8055b2b1
20 changed files with 67 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files
www/iridium/Makefile
+1 -1
View File
@@ -1,5 +1,5 @@
PORTNAME= iridium
PORTVERSION= 2026.05.148.2
PORTVERSION= 2026.05.148.3
PULSEMV= 16
PULSEV= ${PULSEMV}.1
CATEGORIES= www wayland
www/iridium/distinfo
+3 -3
View File
@@ -1,6 +1,6 @@
TIMESTAMP = 1779368357
SHA256 (iridium-browser-2026.05.148.2.tar.xz) = 29d6f834e4f070b117d141a82dff6b00c7371db5ad1e82733a754477a03afb7f
SIZE (iridium-browser-2026.05.148.2.tar.xz) = 1400426188
TIMESTAMP = 1780381497
SHA256 (iridium-browser-2026.05.148.3.tar.xz) = cbaa845c2e769bfa18621abca09f4fd0da1e7812ade270921743b78ba56ca31f
SIZE (iridium-browser-2026.05.148.3.tar.xz) = 1400514344
SHA256 (pulseaudio-16.1.tar.gz) = 027266c62f2a84422ac45fa721a649508f0f1628fb1fd9242315ac54ce2d7c92
SIZE (pulseaudio-16.1.tar.gz) = 2763111
SHA256 (rust/crates/Inflector-0.11.4.crate) = fe438c63458706e03479442743baae6c88256498e6431708f6dfc520a26515d3
www/iridium/files/patch-base_system_sys__info__freebsd.cc
+5 -7
View File
@@ -1,6 +1,6 @@
--- base/system/sys_info_freebsd.cc.orig 2026-02-16 10:45:29 UTC
--- base/system/sys_info_freebsd.cc.orig 2026-06-02 06:11:14 UTC
+++ base/system/sys_info_freebsd.cc
@@ -10,21 +10,75 @@
@@ -10,21 +10,73 @@
#include "base/notreached.h"
#include "base/numerics/safe_conversions.h"
@@ -42,7 +42,7 @@
+ByteSize SysInfo::AmountOfAvailablePhysicalMemoryImpl() {
+ int page_size, r = 0;
+ unsigned int pgfree, pginact, pgcache;
+ unsigned int pgfree, pginact;
+ size_t size = sizeof(page_size);
+ size_t szpg = sizeof(pgfree);
+
@@ -52,15 +52,13 @@
+ r = sysctlbyname("vm.stats.vm.v_free_count", &pgfree, &szpg, NULL, 0);
+ if (r == 0)
+ r = sysctlbyname("vm.stats.vm.v_inactive_count", &pginact, &szpg, NULL, 0);
+ if (r == 0)
+ r = sysctlbyname("vm.stats.vm.v_cache_count", &pgcache, &szpg, NULL, 0);
+
+ if (r == -1) {
+ NOTREACHED();
+ return ByteSize(0);
+ }
+
+ return ByteSize((pgfree + pginact + pgcache) * checked_cast<unsigned>(page_size));
+ return ByteSize((pgfree + pginact) * checked_cast<unsigned>(page_size));
+}
+
// static
@@ -80,7 +78,7 @@
uint64_t SysInfo::MaxSharedMemorySize() {
size_t limit;
size_t size = sizeof(limit);
@@ -32,6 +86,18 @@ uint64_t SysInfo::MaxSharedMemorySize() {
@@ -32,6 +84,18 @@ uint64_t SysInfo::MaxSharedMemorySize() {
NOTREACHED();
}
return static_cast<uint64_t>(limit);
www/iridium/files/patch-chrome_browser_ui_views_frame_browser__view.cc
+4 -4
View File
@@ -1,6 +1,6 @@
--- chrome/browser/ui/views/frame/browser_view.cc.orig 2026-05-13 08:49:22 UTC
--- chrome/browser/ui/views/frame/browser_view.cc.orig 2026-06-02 06:11:14 UTC
+++ chrome/browser/ui/views/frame/browser_view.cc
@@ -2475,7 +2475,7 @@ void BrowserView::ToolbarSizeChanged(bool is_animating
@@ -2476,7 +2476,7 @@ void BrowserView::ToolbarSizeChanged(bool is_animating
}
void BrowserView::TabDraggingStatusChanged(bool is_dragging) {
@@ -9,7 +9,7 @@
UpdateFastResizeForContentViews(is_dragging);
if (!is_dragging) {
@@ -6000,7 +6000,7 @@ void BrowserView::MaybeShowProfileSwitchIPH() {
@@ -6002,7 +6002,7 @@ void BrowserView::MaybeShowProfileSwitchIPH() {
}
void BrowserView::MaybeShowSupervisedUserProfileSignInIPH() {
@@ -18,7 +18,7 @@
if (!ShouldShowAvatarToolbarIPH()) {
return;
}
@@ -6010,7 +6010,7 @@ void BrowserView::MaybeShowSupervisedUserProfileSignIn
@@ -6012,7 +6012,7 @@ void BrowserView::MaybeShowSupervisedUserProfileSignIn
}
void BrowserView::MaybeShowSignInBenefitsIPH() {
www/iridium/files/patch-components_password__manager_core_browser_features_password__features.cc
+11 -2
View File
@@ -1,4 +1,4 @@
--- components/password_manager/core/browser/features/password_features.cc.orig 2026-05-11 13:57:04 UTC
--- components/password_manager/core/browser/features/password_features.cc.orig 2026-06-02 06:11:14 UTC
+++ components/password_manager/core/browser/features/password_features.cc
@@ -78,7 +78,7 @@ BASE_FEATURE(kClearUndecryptablePasswords,
BASE_FEATURE(kClearUndecryptablePasswordsOnSync,
@@ -9,7 +9,16 @@
base::FEATURE_ENABLED_BY_DEFAULT
#else
base::FEATURE_DISABLED_BY_DEFAULT
@@ -174,7 +174,7 @@ BASE_FEATURE(kReduceRequirementsForPasswordChange,
@@ -118,7 +118,7 @@ BASE_FEATURE(kFillChangePasswordFormByTyping,
BASE_FEATURE(kFillOnAccountSelect,
"fill-on-account-select",
// TODO(504600482): Disable the feature again upon fixing the bug.
-#if BUILDFLAG(IS_LINUX)
+#if BUILDFLAG(IS_LINUX) || BUILDFLAG(IS_BSD)
base::FEATURE_ENABLED_BY_DEFAULT
#else
base::FEATURE_DISABLED_BY_DEFAULT
@@ -180,7 +180,7 @@ BASE_FEATURE(kReduceRequirementsForPasswordChange,
BASE_FEATURE(kPasswordCheckupPrototype, base::FEATURE_DISABLED_BY_DEFAULT);
www/iridium/files/patch-content_browser_gpu_gpu__data__manager__impl.cc
+2 -2
View File
@@ -1,6 +1,6 @@
--- content/browser/gpu/gpu_data_manager_impl.cc.orig 2025-12-10 15:04:57 UTC
--- content/browser/gpu/gpu_data_manager_impl.cc.orig 2026-06-02 06:11:14 UTC
+++ content/browser/gpu/gpu_data_manager_impl.cc
@@ -412,7 +412,7 @@ void GpuDataManagerImpl::OnDisplayMetricsChanged(
@@ -427,7 +427,7 @@ void GpuDataManagerImpl::OnDisplayMetricsChanged(
private_->OnDisplayMetricsChanged(display, changed_metrics);
}
www/iridium/files/patch-content_browser_gpu_gpu__data__manager__impl.h
+2 -2
View File
@@ -1,6 +1,6 @@
--- content/browser/gpu/gpu_data_manager_impl.h.orig 2025-12-10 15:04:57 UTC
--- content/browser/gpu/gpu_data_manager_impl.h.orig 2026-06-02 06:11:14 UTC
+++ content/browser/gpu/gpu_data_manager_impl.h
@@ -224,7 +224,7 @@ class CONTENT_EXPORT GpuDataManagerImpl : public GpuDa
@@ -233,7 +233,7 @@ class CONTENT_EXPORT GpuDataManagerImpl : public GpuDa
void OnDisplayMetricsChanged(const display::Display& display,
uint32_t changed_metrics) override;
www/iridium/files/patch-content_browser_gpu_gpu__data__manager__impl__private.cc
+2 -2
View File
@@ -1,6 +1,6 @@
--- content/browser/gpu/gpu_data_manager_impl_private.cc.orig 2026-03-24 16:59:08 UTC
--- content/browser/gpu/gpu_data_manager_impl_private.cc.orig 2026-06-02 06:11:14 UTC
+++ content/browser/gpu/gpu_data_manager_impl_private.cc
@@ -1720,7 +1720,7 @@ void GpuDataManagerImplPrivate::RecordCompositingMode(
@@ -1747,7 +1747,7 @@ void GpuDataManagerImplPrivate::RecordCompositingMode(
UMA_HISTOGRAM_ENUMERATION("GPU.CompositingMode", compositing_mode);
}
www/iridium/files/patch-content_browser_gpu_gpu__data__manager__impl__private.h
+3 -3
View File
@@ -1,6 +1,6 @@
--- content/browser/gpu/gpu_data_manager_impl_private.h.orig 2025-12-10 15:04:57 UTC
--- content/browser/gpu/gpu_data_manager_impl_private.h.orig 2026-06-02 06:11:14 UTC
+++ content/browser/gpu/gpu_data_manager_impl_private.h
@@ -149,7 +149,7 @@ class CONTENT_EXPORT GpuDataManagerImplPrivate {
@@ -152,7 +152,7 @@ class CONTENT_EXPORT GpuDataManagerImplPrivate {
void OnDisplayMetricsChanged(const display::Display& display,
uint32_t changed_metrics);
@@ -9,7 +9,7 @@
bool IsGpuMemoryBufferNV12Supported();
#endif // BUILDFLAG(IS_LINUX)
@@ -311,7 +311,7 @@ class CONTENT_EXPORT GpuDataManagerImplPrivate {
@@ -315,7 +315,7 @@ class CONTENT_EXPORT GpuDataManagerImplPrivate {
bool application_is_visible_ = true;
bool disable_gpu_compositing_ = false;
www/iridium/files/patch-content_browser_gpu_gpu__process__host.cc
+2 -2
View File
@@ -1,4 +1,4 @@
--- content/browser/gpu/gpu_process_host.cc.orig 2025-12-10 15:04:57 UTC
--- content/browser/gpu/gpu_process_host.cc.orig 2026-06-02 06:11:14 UTC
+++ content/browser/gpu/gpu_process_host.cc
@@ -282,6 +282,7 @@ static const char* const kSwitchNames[] = {
switches::kDisableSkiaGraphite,
@@ -8,7 +8,7 @@
switches::kProfilingAtStart,
switches::kProfilingFile,
switches::kProfilingFlush,
@@ -307,7 +308,7 @@ static const char* const kSwitchNames[] = {
@@ -306,7 +307,7 @@ static const char* const kSwitchNames[] = {
switches::kEnableNativeGpuMemoryBuffers,
switches::kRenderNodeOverride,
#endif
www/iridium/files/patch-content_browser_renderer__host_render__widget__host__view__aura.cc
+6 -6
View File
@@ -1,6 +1,6 @@
--- content/browser/renderer_host/render_widget_host_view_aura.cc.orig 2026-05-11 13:57:04 UTC
--- content/browser/renderer_host/render_widget_host_view_aura.cc.orig 2026-06-02 06:11:14 UTC
+++ content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -129,7 +129,7 @@
@@ -130,7 +130,7 @@
#include "ui/gfx/win/gdi_util.h"
#endif // BUILDFLAG(IS_WIN)
@@ -9,7 +9,7 @@
#include "ui/accessibility/platform/browser_accessibility_auralinux.h"
#include "ui/base/ime/linux/text_edit_command_auralinux.h"
#include "ui/base/ime/text_input_flags.h"
@@ -554,7 +554,7 @@ gfx::NativeViewAccessible RenderWidgetHostViewAura::Ge
@@ -555,7 +555,7 @@ gfx::NativeViewAccessible RenderWidgetHostViewAura::Ge
return ToBrowserAccessibilityWin(manager->GetBrowserAccessibilityRoot())
->GetCOM();
@@ -18,7 +18,7 @@
ui::BrowserAccessibilityManager* manager =
host()->GetOrCreateRootBrowserAccessibilityManager();
if (manager && manager->GetBrowserAccessibilityRoot())
@@ -1984,7 +1984,7 @@ bool RenderWidgetHostViewAura::ShouldDoLearning() {
@@ -2003,7 +2003,7 @@ bool RenderWidgetHostViewAura::ShouldDoLearning() {
return host() && host()->delegate() && host()->delegate()->ShouldDoLearning();
}
@@ -27,7 +27,7 @@
bool RenderWidgetHostViewAura::SetCompositionFromExistingText(
const gfx::Range& range,
const std::vector<ui::ImeTextSpan>& ui_ime_text_spans) {
@@ -3016,7 +3016,7 @@ bool RenderWidgetHostViewAura::NeedsInputGrab() {
@@ -3046,7 +3046,7 @@ bool RenderWidgetHostViewAura::NeedsInputGrab() {
}
bool RenderWidgetHostViewAura::NeedsMouseCapture() {
@@ -36,7 +36,7 @@
return NeedsInputGrab();
#else
return false;
@@ -3202,7 +3202,7 @@ void RenderWidgetHostViewAura::ForwardKeyboardEventWit
@@ -3256,7 +3256,7 @@ void RenderWidgetHostViewAura::ForwardKeyboardEventWit
if (!target_host)
return;
www/iridium/files/patch-gpu_command__buffer_service_gles2__cmd__decoder.cc
+2 -2
View File
@@ -1,6 +1,6 @@
--- gpu/command_buffer/service/gles2_cmd_decoder.cc.orig 2026-05-11 13:57:04 UTC
--- gpu/command_buffer/service/gles2_cmd_decoder.cc.orig 2026-06-02 06:11:14 UTC
+++ gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -2857,7 +2857,7 @@ std::unique_ptr<GLES2Decoder> GLES2Decoder::Create(
@@ -2865,7 +2865,7 @@ std::unique_ptr<GLES2Decoder> GLES2Decoder::Create(
}
// Allow linux to run fuzzers.
www/iridium/files/patch-gpu_command__buffer_service_shared__image_shared__image__factory.cc
+5 -5
View File
@@ -1,4 +1,4 @@
--- gpu/command_buffer/service/shared_image/shared_image_factory.cc.orig 2026-05-11 13:57:04 UTC
--- gpu/command_buffer/service/shared_image/shared_image_factory.cc.orig 2026-06-02 06:11:14 UTC
+++ gpu/command_buffer/service/shared_image/shared_image_factory.cc
@@ -55,7 +55,7 @@
#include "gpu/command_buffer/service/shared_image/angle_vulkan_image_backing_factory.h"
@@ -9,7 +9,7 @@
#include "gpu/command_buffer/service/shared_image/external_vk_image_backing_factory.h"
#endif
@@ -118,7 +118,7 @@ const char* GmbTypeToString(gfx::GpuMemoryBufferType t
@@ -123,7 +123,7 @@ const char* GmbTypeToString(gfx::GpuMemoryBufferType t
case gfx::IO_SURFACE_BUFFER:
return "platform";
#endif
@@ -18,7 +18,7 @@
case gfx::NATIVE_PIXMAP:
return "platform";
#endif
@@ -139,7 +139,7 @@ gfx::GpuMemoryBufferType GetNativeBufferType() {
@@ -144,7 +144,7 @@ gfx::GpuMemoryBufferType GetNativeBufferType() {
return gfx::GpuMemoryBufferType::IO_SURFACE_BUFFER;
#elif BUILDFLAG(IS_ANDROID)
return gfx::GpuMemoryBufferType::ANDROID_HARDWARE_BUFFER;
@@ -27,7 +27,7 @@
return gfx::GpuMemoryBufferType::NATIVE_PIXMAP;
#elif BUILDFLAG(IS_WIN)
return gfx::GpuMemoryBufferType::DXGI_SHARED_HANDLE;
@@ -316,7 +316,7 @@ SharedImageFactory::SharedImageFactory(
@@ -322,7 +322,7 @@ SharedImageFactory::SharedImageFactory(
factories_.push_back(std::move(ozone_factory));
}
@@ -36,7 +36,7 @@
if (gr_context_type_ == GrContextType::kVulkan
#if BUILDFLAG(USE_WEBGPU_ON_VULKAN_VIA_GL_INTEROP)
/* We support GL context for WebGPU gl-vulkan interop (on linux).*/
@@ -1040,7 +1040,7 @@ void SharedImageFactory::LogGetFactoryFailed(gpu::Shar
@@ -1051,7 +1051,7 @@ void SharedImageFactory::LogGetFactoryFailed(gpu::Shar
}
#endif // BUILDFLAG(IS_ANDROID)
www/iridium/files/patch-gpu_vulkan_vulkan__image.h
+2 -2
View File
@@ -1,4 +1,4 @@
--- gpu/vulkan/vulkan_image.h.orig 2025-12-10 15:04:57 UTC
--- gpu/vulkan/vulkan_image.h.orig 2026-06-02 06:11:14 UTC
+++ gpu/vulkan/vulkan_image.h
@@ -86,7 +86,7 @@ class COMPONENT_EXPORT(VULKAN) VulkanImage {
VkImageUsageFlags usage,
@@ -9,7 +9,7 @@
static std::unique_ptr<VulkanImage> CreateWithExternalMemoryAndModifiers(
VulkanDeviceQueue* device_queue,
const gfx::Size& size,
@@ -198,7 +198,7 @@ class COMPONENT_EXPORT(VULKAN) VulkanImage {
@@ -210,7 +210,7 @@ class COMPONENT_EXPORT(VULKAN) VulkanImage {
VkImageTiling image_tiling,
uint32_t queue_family_index);
www/iridium/files/patch-media_gpu_chromeos_gl__image__processor__backend.cc
+2 -2
View File
@@ -1,6 +1,6 @@
--- media/gpu/chromeos/gl_image_processor_backend.cc.orig 2026-04-15 12:07:04 UTC
--- media/gpu/chromeos/gl_image_processor_backend.cc.orig 2026-06-02 06:11:14 UTC
+++ media/gpu/chromeos/gl_image_processor_backend.cc
@@ -27,6 +27,10 @@
@@ -28,6 +28,10 @@
#include "ui/ozone/public/ozone_platform.h"
#include "ui/ozone/public/surface_factory_ozone.h"
www/iridium/files/patch-services_device_public_cpp_device__features.cc
+2 -2
View File
@@ -1,6 +1,6 @@
--- services/device/public/cpp/device_features.cc.orig 2026-04-16 10:10:12 UTC
--- services/device/public/cpp/device_features.cc.orig 2026-06-02 06:11:14 UTC
+++ services/device/public/cpp/device_features.cc
@@ -135,11 +135,11 @@ bool IsOsLevelGeolocationPermissionSupportEnabled() {
@@ -152,11 +152,11 @@ bool IsOsLevelGeolocationPermissionSupportEnabled() {
// a USB interface is busy.
#if BUILDFLAG(IS_ANDROID)
BASE_FEATURE(kAutomaticUsbDetach, base::FEATURE_ENABLED_BY_DEFAULT);
www/iridium/files/patch-services_device_public_cpp_device__features.h
+2 -2
View File
@@ -1,6 +1,6 @@
--- services/device/public/cpp/device_features.h.orig 2026-04-16 10:10:12 UTC
--- services/device/public/cpp/device_features.h.orig 2026-06-02 06:11:14 UTC
+++ services/device/public/cpp/device_features.h
@@ -54,11 +54,11 @@ extern const DEVICE_FEATURES_EXPORT
@@ -58,11 +58,11 @@ extern const DEVICE_FEATURES_EXPORT
DEVICE_FEATURES_EXPORT bool IsOsLevelGeolocationPermissionSupportEnabled();
www/iridium/files/patch-third__party_blink_renderer_platform_runtime__enabled__features.json5
+5 -5
View File
@@ -1,4 +1,4 @@
--- third_party/blink/renderer/platform/runtime_enabled_features.json5.orig 2026-05-11 13:57:04 UTC
--- third_party/blink/renderer/platform/runtime_enabled_features.json5.orig 2026-06-02 06:11:14 UTC
+++ third_party/blink/renderer/platform/runtime_enabled_features.json5
@@ -411,7 +411,7 @@
name: "AIPromptAPILegacyParams",
@@ -90,7 +90,7 @@
public: true,
base_feature_status: "enabled",
copied_from_base_feature_if: "overridden",
@@ -6001,7 +6001,7 @@
@@ -6009,7 +6009,7 @@
name: "UnrestrictedSharedArrayBuffer",
base_feature: "none",
origin_trial_feature_name: "UnrestrictedSharedArrayBuffer",
@@ -99,7 +99,7 @@
},
// Enables using policy-controlled feature "usb-unrestricted" to allow
// isolated context to access protected USB interface classes and to
@@ -6098,7 +6098,7 @@
@@ -6106,7 +6106,7 @@
status: "experimental",
origin_trial_feature_name: "UserMediaElement",
public: true,
@@ -108,7 +108,7 @@
base_feature_status: "enabled",
copied_from_base_feature_if: "overridden",
},
@@ -6209,7 +6209,7 @@
@@ -6217,7 +6217,7 @@
name: "WebAppInstallation",
status: {"Android": "", "default": "test"},
origin_trial_feature_name: "WebAppInstallation",
@@ -117,7 +117,7 @@
public: true,
base_feature_status: "enabled",
copied_from_base_feature_if: "overridden",
@@ -6223,7 +6223,7 @@
@@ -6231,7 +6231,7 @@
{
name: "WebAppScopeExtensions",
origin_trial_feature_name: "WebAppScopeExtensions",
www/iridium/files/patch-ui_views_controls_textfield_textfield.cc
+4 -4
View File
@@ -1,4 +1,4 @@
--- ui/views/controls/textfield/textfield.cc.orig 2026-05-11 13:57:04 UTC
--- ui/views/controls/textfield/textfield.cc.orig 2026-06-02 06:11:14 UTC
+++ ui/views/controls/textfield/textfield.cc
@@ -88,7 +88,7 @@
#include "base/win/win_util.h"
@@ -36,7 +36,7 @@
// Skip any accelerator handling that conflicts with custom keybindings.
if (auto* linux_ui = ui::LinuxUi::instance()) {
if (IsTextEditCommandEnabled(linux_ui->GetTextEditCommandForEvent(
@@ -2092,7 +2092,7 @@ bool Textfield::ShouldDoLearning() {
@@ -2100,7 +2100,7 @@ bool Textfield::ShouldDoLearning() {
return false;
}
@@ -45,7 +45,7 @@
// TODO(crbug.com/41452689): Implement this method to support Korean IME
// reconversion feature on native text fields (e.g. find bar).
bool Textfield::SetCompositionFromExistingText(
@@ -2619,7 +2619,7 @@ ui::TextEditCommand Textfield::GetCommandForKeyEvent(
@@ -2627,7 +2627,7 @@ ui::TextEditCommand Textfield::GetCommandForKeyEvent(
#endif
return ui::TextEditCommand::DELETE_BACKWARD;
}
@@ -54,7 +54,7 @@
// Only erase by line break on Linux and ChromeOS.
if (shift) {
return ui::TextEditCommand::DELETE_TO_BEGINNING_OF_LINE;
@@ -2627,7 +2627,7 @@ ui::TextEditCommand Textfield::GetCommandForKeyEvent(
@@ -2635,7 +2635,7 @@ ui::TextEditCommand Textfield::GetCommandForKeyEvent(
#endif
return ui::TextEditCommand::DELETE_WORD_BACKWARD;
case ui::VKEY_DELETE:
www/iridium/files/patch-ui_views_controls_textfield_textfield.h
+2 -2
View File
@@ -1,4 +1,4 @@
--- ui/views/controls/textfield/textfield.h.orig 2026-05-11 13:57:04 UTC
--- ui/views/controls/textfield/textfield.h.orig 2026-06-02 06:11:14 UTC
+++ ui/views/controls/textfield/textfield.h
@@ -51,7 +51,7 @@
#include "ui/views/view_observer.h"
@@ -9,7 +9,7 @@
#include <vector>
#endif
@@ -483,7 +483,7 @@ class VIEWS_EXPORT Textfield : public View,
@@ -484,7 +484,7 @@ class VIEWS_EXPORT Textfield : public View,
// Set whether the text should be used to improve typing suggestions.
void SetShouldDoLearning(bool value) { should_do_learning_ = value; }