mirror of
https://git.freebsd.org/ports.git
synced 2026-06-02 11:08:52 +00:00
Dimitry Andric
1d3ebc8948
With clang 21 comms/bladerf fails to build, with errors similar to:
/wrkdirs/usr/ports/comms/bladerf/work/bladeRF-2025.10/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare]
71 | if (val[i] >= 'a' || val[i] <= 'f') {
| ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
This is a logic error: the logical operator should be `&&` here. It has
been proposed as an upstream pull request:
https://github.com/Nuand/bladeRF/pull/1045, but it is not yet merged.
PR: 293393
Approved by: maintainer timeout (2 weeks)
MFH: 2026Q1